Page 1 of 1

[SOLVED] Agent Only Callbacks without Manual Dial

PostPosted: Fri Oct 19, 2018 3:11 pm
by khuff
Is there a way to use Agent Only Callbacks without enabling Manual dial, or a way to enable manual dial for only callbacks. We want agents to be able to do callbacks but don't want them to have the freedom to dial any number.

My initial thought was to move callbacks into a special list and filter the manual dial to just that list but looks like it has to be all campaign lists.

Any other ideas on how I can keep agents from manual dailing stuff that isn't a callback?

Re: Agent Only Callbacks without Manual Dial

PostPosted: Fri Oct 19, 2018 3:26 pm
by williamconley
i don't think that feature exists. Seems like it wouldn't be particularly hard to build. So you're looking for "no new numbers: ONLY dial numbers that are already available in the system? Could add that to the available dropdown items for "Manual Dial Search Checkbox". Similar to "LOCK", but with "NONEW" as the addon.

Re: Agent Only Callbacks without Manual Dial

PostPosted: Fri Oct 19, 2018 3:40 pm
by khuff
We'd want it more restrictive than that. We'd only want them to be able to manual dial scheduled callbacks that are agent only. Checking out the most recent SVN looks like the last change was adding an option to the manual dial filter so I should be able to copy that pretty easy to build it myself. If it is good enough how would I go about doing a PR for it?

Re: Agent Only Callbacks without Manual Dial

PostPosted: Fri Oct 19, 2018 3:45 pm
by williamconley
click on "Vicidial Issue Tracker" at the top of this page. Post a link to the issue you created here in this thread so the discussion can lead to the Issue easily.

Re: Agent Only Callbacks without Manual Dial

PostPosted: Fri Oct 19, 2018 3:47 pm
by khuff
Oh boy, looks super easy, and that previous update tells me exactly what I need to update. I'll throw it together this weekend. Would like to get it in the svn, so thanks for the info.

Re: Agent Only Callbacks without Manual Dial

PostPosted: Fri Oct 19, 2018 4:06 pm
by williamconley
Everyone thanks you for the cool feature (well, when you finish, of course, lol).

Re: Agent Only Callbacks without Manual Dial

PostPosted: Fri Oct 19, 2018 4:35 pm
by khuff
Easy squeezie, lucked out that the most recent change was in a similar vein to what I needed, otherwise would have taken quite a bit longer to figure out everything I needed to update. Uploaded my changes to the bug tracker. Was going to test but my test server is way out of date and it is Friday. I'll give it a test this weekend and update the status. Happy to contribute, been using vicidial for a long time and feel I owe something to the community, it's the least I can do. (Also a little selfish due to not having to worry about the custom changes during updates if it get's into the svn.)

Re: Agent Only Callbacks without Manual Dial

PostPosted: Fri Oct 19, 2018 4:55 pm
by williamconley
khuff wrote:(Also a little selfish due to not having to worry about the custom changes during updates if it get's into the svn.)

Absolutely the best reason to do it. Wish I could convince customers of this concept! lol

Re: Agent Only Callbacks without Manual Dial

PostPosted: Mon Oct 22, 2018 9:54 pm
by khuff
I got a working version. Updated the bug tracker, I hope they pick it up. It checks for an entry for the lead_id pulled by the manual dial code in the vicidial_callbacks table. If it finds an entry there the callback can go through, if not it won't. Also added an option to check it against the dnc list also. Here's the code if it'll be helpful to anyone. Works on SVN Revision 3051.

http://www.vicidial.org/VICIDIALmantis/view.php?id=1139

Re: [SOLVED] Agent Only Callbacks without Manual Dial

PostPosted: Mon Oct 22, 2018 11:23 pm
by williamconley
Don't post a google docs link here, post the link to the DIFF you filed in the issue tracker. Google docs tends to invade privacy, some are not appreciative.

Re: [SOLVED] Agent Only Callbacks without Manual Dial

PostPosted: Tue Oct 23, 2018 11:05 am
by khuff
Sounds reasonable. I thought about doing a diff but didn't really cross my mind last night. I've added them to the bug tracker. Thanks for the suggestion.