Quick Submit!

Discussions about new features or changes in existing features

Moderators: gerski, enjay, williamconley, Op3r, Staydog, gardo, mflorell, MJCoate, mcargile, Kumba, Michael_N

Quick Submit!

Postby martinch » Mon Mar 06, 2023 5:08 pm

Hey guys,

Is there any desire for a Quick Submit button on some of those long pages that we have to make regular changes to? I thought it might be a nice feature for me personally;

Floating Quick Submit button on Campaign Detailed Settings;

Image

Proposal;

- New System Settings options;
- "Quick Submit Active" ENUM("Y", "N").
- "Quick Submit Button Colour (Hex Colour).
- "Quick Submit Button Position (Top Left, Top Right, Bottom Left, Bottom Right, Middle Left, Middle Right).

- Pages covered;
- Campaigns - Detailed page.
- User Settings page.
- Ingroup Settings page.
- Phones page.
- System Settings page.

I've developed the feature so will submit on Mantis shortly for consideration. Thanks guys. Martin.
Project Lead @ mDial -> https://github.com/TheBlode/mDial
martinch
 
Posts: 273
Joined: Thu Nov 15, 2018 9:14 am
Location: England, UK

Re: Quick Submit!

Postby mflorell » Mon Mar 06, 2023 6:16 pm

Looks cool, thanks for contributing!
mflorell
Site Admin
 
Posts: 18334
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Re: Quick Submit!

Postby martinch » Wed Mar 15, 2023 3:50 pm

Thanks Matt. :)

Feature code submitted http://www.vicidial.org/VICIDIALmantis/view.php?id=1454

Code: Select all
=============================================
Quick Submit on Admin Panel.
=============================================

Ticket Type: Add Feature.
Reporter: Martin McCarthy (martinch).
Impacted Users: ViCiDial Administrators who like to make frequent changes to ViCiDial cluster settings.
Priority: Low.
Product(s) Affected: ViCiDial.
Deadline: No firm deadline in place.
Time / Effort Estimate: 1 hour of development / 1 hour of QA testing.

=============================================
Description
=============================================

ViCiDial administrators that regularly make changes to ViCiDial have to scroll through lots of options to submit maybe one or two changes. My idea is to introduced a sticky Submit button on some of the longer pages to allow for quick submission of forms to save a bit of time.

Tasks;

- Implement a function in functions.php to render the Quick Submit button.
- Added the function call to the follow long list pages;
    - system settings.
    - campaign detailed view.
    - modify users page.
    - modify in-group settings page.
    - modify phones page.

If you have any queries, please reach out to me.

=============================================
End
=============================================


Supported options;

- Toggle switch to turn button on and off.
- Option to change the button position (top left, top right, bottom left, bottom right).
- Option to change button color using a hex value.

Example of button on bottom left of the system settings page in green.

Image
Project Lead @ mDial -> https://github.com/TheBlode/mDial
martinch
 
Posts: 273
Joined: Thu Nov 15, 2018 9:14 am
Location: England, UK

Re: Quick Submit!

Postby martinch » Fri Jun 02, 2023 6:35 am

So Chris left a message on the Mantis board regarding this ticket and he made a very pertinent point which I vibe with completely 100%! So I mean, this feature is kinda like "meh" and I respect that but it's based on real world example that I have faced...I have dialler managers that tend to make little changes throughout the day to their campaigns, tiny little tweaks, maybe dial level or whathaveyou...and this kinda came to mind. However, Chris has suggested an even easier and fast way to commit these settings! He said just use the Return key / Enter key. It's as simple as that! So if a admin changes the dial level from 1.0 to 2.0 they hit the Enter key and boom, the setting submitted. He said that this is OOTB functionality...but I personally haven't tested that...but I will test it and if that is the case, I will just pass that on and this feature can be shelved. :) if it doesn't work like that, it would be a formality to add an event handler to respond to that keypress. Either way, it's just nice and quick to submit changes very quickly on long pages. Cheers again Chris :)
Project Lead @ mDial -> https://github.com/TheBlode/mDial
martinch
 
Posts: 273
Joined: Thu Nov 15, 2018 9:14 am
Location: England, UK

Re: Quick Submit!

Postby carpenox » Thu Jun 08, 2023 2:58 am

No sweat bro I love all your ideas I just saw this one as just an over sight to an existing feature just done another way
Alma Linux 9.3 | Version: 2.14-911a | SVN Version: 3815 | DB Schema Version: 1710 | Asterisk 18.18.1
www.dialer.one -:- 1-833-DIALER-1 -:- https://linktr.ee/CyburDial -:- WhatsApp: +19549477572 -:- Skype: live:carpenox_3
carpenox
 
Posts: 2223
Joined: Wed Apr 08, 2020 2:02 am
Location: Coral Springs, FL

Re: Quick Submit!

Postby mflorell » Thu Jun 08, 2023 8:12 am

One issue with the Return/Enter key is if the person has highlighted a select list. The browser behavior is to select the current highlighted item in the list when Enter/Return is pressed. Adding a capture behavior on that key may change the expected behavior depending on the browser that is used.
mflorell
Site Admin
 
Posts: 18334
Joined: Wed Jun 07, 2006 2:45 pm
Location: Florida

Re: Quick Submit!

Postby carpenox » Thu Jun 08, 2023 11:09 am

Good catch, I didn't take that into consideration
Alma Linux 9.3 | Version: 2.14-911a | SVN Version: 3815 | DB Schema Version: 1710 | Asterisk 18.18.1
www.dialer.one -:- 1-833-DIALER-1 -:- https://linktr.ee/CyburDial -:- WhatsApp: +19549477572 -:- Skype: live:carpenox_3
carpenox
 
Posts: 2223
Joined: Wed Apr 08, 2020 2:02 am
Location: Coral Springs, FL

Re: Quick Submit!

Postby martinch » Fri Jun 16, 2023 3:46 pm

Cheers fellas, so the Enter/Return key event handler does submit the form on text inputs which is great...doesn't work on select inputs but you know what, I think my dialler managers are going to be okay with that I think as half the inputs are text :) but yeah Matt, I agree, maybe I'm over-egging the pudding a bit here but yeah. Not every idea that comes to my mind is a good one that's for sure and this piece is proof of that :)
Project Lead @ mDial -> https://github.com/TheBlode/mDial
martinch
 
Posts: 273
Joined: Thu Nov 15, 2018 9:14 am
Location: England, UK


Return to Features

Who is online

Users browsing this forum: No registered users and 11 guests