List mix problem

[bryceowen]

V: 2.2.0-215, B: 90908-1207

Took me a while to track it down, but I found a small problem that was kicking my butt. I don't know if this has been corrected already and I'm not really sure how to search for it in the issue tracker, so I apologize if this has already been addressed.

On the List Mixes view (add=31) in this build, there's a select box at the bottom that allows you to modify all of the selected lists' statuses at once. (Very handy for a mix with 10 lists.) The problem I found is that, when you click on a status to add, it clears the default options (DROP NA A B NEW -) and inserts the newly selected status. However, it doesn't insert the leading - (minus). As a result, when you apply the selected statuses to all lists, the AST_VDhopper_MIXtest.pl fails to add an ' (apostrophe) to the end (line 1149).

Sadly, I don't have a copy of the admin.php for this particular version and build, (I don't have permission to access the server directly. All my troubleshooting is done the hard, hard way.) otherwise I could tell you exactly what line needs to be addressed. Best I can do is tell you it's near line 14833 (looking at the admin.php from V2.0.5-173, B90320-0424), where it probably says:

Code: Select all

echo "<input type=hidden name=status".$US."X$US$vlc_id id=status".$US."X$US$vlc_id value=\"\">\n";


I think the value should equal \" -\" rather than \"\".

[williamconley]

you may do best to place this detailed information directly into the issue tracker and if it is indeed a dupe it will be marked as such. if not, it will get resolved and you'll get thanked either way.

[mflorell]

The AST_VDhopper_MIXtest.pl script is depricated in that version of the 2.2.0 tree. Are you sure that is the one that is being used and not the AST_VDhopper.pl script?

[bryceowen]

William:
I suppose I could. I'm not sure what version of Asterisk we're using. Is there any way to find out from the VICIdial interface?

Matt:
The exact error we were getting was:

DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '13.00','12.75','12.50','12.25','12.00','11.75','11.50','11.25','11.00','10.75','' at line 1 at /usr/share/astguiclient/AST_VDhopper_MIXtest.pl line 1198.
executing: SELECT count(*) FROM vicidial_list where called_since_last_reset='N' and ((list_id='113' and status IN('ONI','NP','NI','NEW','NA','N','INFO','DROP','DC','CALLBK','B','AM','AL','AB','AA','A))) and ((gmt_offset_now IN('13.00','12.75','12.50','12.25','12.00','11.75','11.50','11.25','11.00','10.75','10.50','10.25','10.00','9.75','-2.50','-2.75','-3.00','-3.25','-3.50','-3.75','-4.00','-4.25','-4.50','-4.75','-5.00','-5.25','-5.50','-5.75','-6.00','-6.25','-6.50','-6.75','-7.00','-7.25','-7.50','-7.75','-8.00','-8.25','-8.50','-8.75','-9.00','-9.25','-9.50','-9.75','-10.00','-10.25','-10.50','-10.75','-11.00','-11.25','-11.50','-11.75','-12.00','-12.25','-12.50','-12.75','99') ) ) ; You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '13.00','12.75','12.50','12.25','12.00','11.75','11.50','11.25','11.00','10.75','' at line 1 at /usr/share/astguiclient/AST_VDhopper_MIXtest.pl line 1198.

I tracked it down to the missing minus by comparing the db entry for this campaign to one that was working.

As a side note, when this (an SQL error loading leads into the hopper) happens, it prevents ANY campaign from loading new leads into their respective hoppers. (They will continue to dial the numbers currently in the hopper, but once exhausted, the campaigns sit idle until the one causing the error is deactivated.)

[mflorell]

Have you tried using the AST_VDhopper.pl script instead?

The other script is DEPRICATED and will not work properly.

[bryceowen]

[Edited]
Nevermind. I didn't think to look two lines down on the AST_VDhopper.pl script and see you added a line that checks for the error I spent an hour or so outlining.

For the record, the problem stems from the admin.php line:

Code: Select all

echo "<input type=hidden name=status$US$X$US$vcl_id id=status$US$X$US$vcl_id value=\"\"><input type=text size=20 maxlength=255 name=ROstatus$US$X$US$vcl_id id=ROstatus$US$X$US$vcl_id value=\"$LMdial_statuses\" READONLY>\n";

If the hidden field has a value of " -" or "$LMdial_statuses", the check in the pl script would be superfluous.